Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified route names again #405

Merged
merged 2 commits into from
Mar 22, 2019
Merged

Unified route names again #405

merged 2 commits into from
Mar 22, 2019

Conversation

mamazu
Copy link
Member

@mamazu mamazu commented Mar 13, 2019

All other routes of the ShopApiPlugin start with sylius_shop_api. Some of the routes don't follow this pattern:
🚨 BC BREAK.

@mamazu mamazu requested a review from a team as a code owner March 13, 2019 15:35
@lchrusciel
Copy link
Member

Solving #190

@mamazu
Copy link
Member Author

mamazu commented Mar 20, 2019

Needs to be documented as well.

@lchrusciel
Copy link
Member

lchrusciel commented Mar 21, 2019 •
edited
Loading

Should be just added to UPGRADE.md (just to keep a track #340)

lchrusciel
lchrusciel approved these changes Mar 22, 2019
View reviewed changes
UPGRADE.md Outdated Show resolved Hide resolved
@lchrusciel lchrusciel merged commit 90ca7a9 into Sylius:master Mar 22, 2019
@lchrusciel
Copy link
Member

Thank you, @mamazu! 🥇

@mamazu mamazu deleted the routing branch March 22, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamazu @lchrusciel